Skip to content

RHOAIENG-54711: Remove dead _component_resources_down method#1039

Merged
openshift-merge-bot[bot] merged 1 commit into
project-codeflare:mainfrom
DavidAdaRH:RHOAIENG-54711
Mar 30, 2026
Merged

RHOAIENG-54711: Remove dead _component_resources_down method#1039
openshift-merge-bot[bot] merged 1 commit into
project-codeflare:mainfrom
DavidAdaRH:RHOAIENG-54711

Conversation

@DavidAdaRH

@DavidAdaRH DavidAdaRH commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue link

https://redhat.atlassian.net/browse/RHOAIENG-54711

What changes have been made

  • Removed the dead _component_resources_down method which was never called and had an incorrect signature that would crash with TypeError if invoked.

Verification steps

  • Grep confirmed no references to _component_resources_down exist in the codebase, and syntax/lint checks pass with no errors.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@DavidAdaRH
RHOAIENG-54711: Remove dead _component_resources_down method
5b097cd 
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@DavidAdaRH DavidAdaRH self-assigned this Mar 25, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
@openshift-ci-robot

openshift-ci-robot commented Mar 25, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Collaborator

@DavidAdaRH: This pull request references RHOAIENG-54711 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Issue link

https://redhat.atlassian.net/browse/RHOAIENG-54711

What changes have been made

  • Removed the dead _component_resources_down method which was never called and had an incorrect signature that would crash with TypeError if invoked.

Verification steps

  • Grep confirmed no references to _component_resources_down exist in the codebase, and syntax/lint checks pass with no errors.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov

codecov Bot commented Mar 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.45%. Comparing base (d87aac4) to head (5b097cd).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   96.15%   96.45%   +0.30%     
==========================================
  Files          23       23              
  Lines        2238     2230       -8     
==========================================
- Hits         2152     2151       -1     
+ Misses         86       79       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavidAdaRH DavidAdaRH removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
@openshift-ci-robot

openshift-ci-robot commented Mar 25, 2026 •
edited by openshift-ci Bot
Loading

Copy link
Copy Markdown
Collaborator

@DavidAdaRH: This pull request references RHOAIENG-54711 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Issue link

https://redhat.atlassian.net/browse/RHOAIENG-54711

What changes have been made

  • Removed the dead _component_resources_down method which was never called and had an incorrect signature that would crash with TypeError if invoked.

Verification steps

  • Grep confirmed no references to _component_resources_down exist in the codebase, and syntax/lint checks pass with no errors.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidAdaRH DavidAdaRH removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
@DavidAdaRH DavidAdaRH marked this pull request as ready for review March 26, 2026 15:37
@openshift-ci openshift-ci Bot requested review from Fiona-Waters and dimakis March 26, 2026 15:37
@laurafitzgerald

laurafitzgerald commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

Dead code removal is the right call here. Deletion is cleaner than trying to fix a method that was never invoked and would have thrown immediately if called.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026
@openshift-ci

openshift-ci Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laurafitzgerald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 2b1f3ac into project-codeflare:main Mar 30, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laurafitzgerald laurafitzgerald Awaiting requested review from laurafitzgerald

@kryanbeane kryanbeane Awaiting requested review from kryanbeane

@chipspeak chipspeak Awaiting requested review from chipspeak

@dimakis dimakis Awaiting requested review from dimakis

@Fiona-Waters Fiona-Waters Awaiting requested review from Fiona-Waters

Assignees

@laurafitzgerald laurafitzgerald

@DavidAdaRH DavidAdaRH

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DavidAdaRH @openshift-ci-robot @laurafitzgerald